openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
787 stars 271 forks source link

The Fast Track road to score is sometimes shown when a product does not need it #4537

Open teolemon opened 1 year ago

teolemon commented 1 year ago

What

image image

Note: I'm not getting the issue. Questions to ponder: did Stéphane (or someone else) do something before the reporting the issue (like completing part of the product?). Was the product local cache/display up to date ?

monsieurtanuki commented 1 year ago

https://fr.openfoodfacts.org/produit/20037154/pasta-sause-basil-combino The fast track road to score is displayed when one of those is not populated (cf. ProductIncompleteCard.isProductIncomplete):

Perhaps we could play it even safer ("ceinture et bretelles") by checking first if nova, nutriscore and ecoscore are computed (which is good enough for us, and wouldn't have displayed the fast track paragraph in the 2nd screenshot).

g123k commented 10 months ago

Perhaps we could play it even safer ("ceinture et bretelles") by checking first if nova, nutriscore and ecoscore are computed (which is good enough for us, and wouldn't have displayed the fast track paragraph in the 2nd screenshot).

I +1 for this approach