Photos Manager: Add a language dropdown

openfoodfacts / smooth-app

The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart

https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo

Apache License 2.0

750 stars 261 forks source link

Photos Manager: Add a language dropdown #4625

Open g123k opened 10 months ago

g123k commented 10 months ago

Hi everyone,

As part of the redesign, we would like to fix a recurring complaint about the relation between the list of photos and the details.

The list of photos currently selects the best photos possible, which may contain photos in different languages. A weird behavior can happen when we click on a photo, because we always use the language of the user in the details (which may result in an unavailable picture)

To simplify things, we will now remove this "best results" algorithm and have a dropdown with a list of languages: Basic details

The mockup is not that beautiful, but it will be changed by the redesign.

monsieurtanuki commented 10 months ago

The "best result" pictures are also displayed in the product thumbnail and in the product carousel. Should we also get rid of both?

g123k commented 10 months ago

The "best result" pictures are also displayed in the product thumbnail and in the product carousel. Should we also get rid of both?

In the redesign, the carousel in the product won't exist anymore. I've no strong opinion on this. Any advice @teolemon?

teolemon commented 10 months ago

product thumbnail should be: app language, or fall back to main product language
We should keep this algorithm for some scenarii (I'm not sure it properly falls back to main product language at the moment) - am i right @monsieurtanuki ?

monsieurtanuki commented 10 months ago

@teolemon Actually there are 2 kinds of images:

the "standard/best" pictures, as computed by the server (imageFrontUrl, imageIngredientsUrl, imageNutritionUrl, imagePackagingUrl) => that's what we use in the top carousel or as the product thumbnail
the localized pictures (product.images), that we use in the edit mode

The idea would be to use only the localized pictures. And keep the "standard/best pictures" only for the carousel or the thumbnail (if kept).