App shows wrong credentials when servers aren't reachable.

AshAman999 commented 9 months ago

What

The error message on the login page says incorrect username or password clearly that same password if I press the sign in button again gets accepted, I assume it was due to problem with my bandwidth, but surely not a correct response from the app

Steps to reproduce the behavior

Go to Profile
Click on 'Sign in.'
Enter your credentials
See error

Expected behavior

The app should show proper message something like loading failed or similar

Why

Got me confused and I was to reset the password on web but found out it works there,

Part of

?

Screenshot/Mockup/Before-After

Smartphone model

Device: iPhone 13
OS: iOS 17.0.3
App Version: 4.9.2+1241-MLKit-AppleAppStore

Additional context

Ps: I am trying to sign in with my email, I think that shouldn't be the problem. Probably some wording with error messages is the cause. packages\smooth_app\lib\pages\user_management\forgot_password_page.dart

monsieurtanuki commented 9 months ago

@AshAman999 The server is rather slow today anyway. You're right, we should make the difference between server down, no internet and wrong user/pwd. Fix needed in user_management_provider.dart (Future<bool> login(User user) async {).

teolemon commented 9 months ago

Good catch 🙂

monsieurtanuki commented 9 months ago

Could be extended to the other cases when the server is down (Exception: JSON expected, html found: <head><title>504 Gateway Time-out</title></head>) or the connection is down. cf. https://openfoodfacts.sentry.io/issues/4409784503/?notification_uuid=c6252a4b-36fc-4a57-bba7-b71fbe4cf870&project=5376745&referrer=weekly_report

openfoodfacts / smooth-app