openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
851 stars 282 forks source link

photo dates not visible on mobile, difficult to know the most up-to-date version #5128

Open monsieurtanuki opened 7 months ago

monsieurtanuki commented 7 months ago

Needs https://github.com/openfoodfacts/openfoodfacts-dart/pull/892

monsieurtanuki commented 7 months ago

off-dart v3.5.0 is not public yet, but we can start to play with the uploaded timestamp using a local off-dart up-to-date package.

Of course several options are available regarding dates:

monsieurtanuki commented 7 months ago

If we put an extra "wrong!" icon on older images (e.g. more than 1 year old), the order of images gets implicit and the "good" and fresh pictures too. @teolemon @jusdekiwi Would that be good?

1 2 3
Screenshot_1712135552 Screenshot_1712135561 Screenshot_1712135578
jusdekiwi commented 7 months ago

Maybe a "warning" icon would be better since old doesn't mean wrong. Also as shown in your previous message, it seems like clicking on the old images would delete them. That's not what we want, is it? Last thing, would it be possible to tell if one "old" image is obsolete or? Because it would be useful to be able to tell that the product has not changed. Otherwise we would have to take new pictures all the time. Thank you for your work anyway!! :)

monsieurtanuki commented 7 months ago

@jusdekiwi It's just a matter of icon: a "warning" icon would be more appropriate indeed. No specific action is intended for the moment anyway (i.e. no "image deleting").

This issue is only about upload timestamps. There is no obsolete flag triggered by a power-user or a producer in Smoothie. The only "obsolete" flag we use (and actually we currently don't) is "OBSOLETE_NUTRITION_IMAGE", that is true if states contain either 'en:nutrition-photo-to-be-selected' or 'en:photos-to-be-uploaded'. Doesn't look very reliable IMHO.

Perhaps we could work on the "upload timestamp" aspect only, then in another issue be more specific about "obsolete" images if needed.

teolemon commented 7 months ago

Web reference

image

Old mockup I did (without headers)

image

jusdekiwi commented 7 months ago

@monsieurtanuki on the webapp it's kind of okay since i can see the dates by hovering the pictures with my cursor. However, on the mobile app, I can't see them. What I would like is having a visible timestamp over or under the pictures uploaded in the mobile app when selected an existing picture. I've made an example below. I am not sure about the warnings, maybe we would need more opinions of contributors. image

teolemon commented 7 months ago

image

monsieurtanuki commented 7 months ago

@jusdekiwi Something like that? Screenshot_1712310068

jusdekiwi commented 7 months ago

Yeah, that would be really good. I'm not sure about the exclamation marks for the old ones though. Maybe a light red/pink background for the text would be more obvious.