openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
800 stars 275 forks source link

feat: 5403 - improvements for "price adding" #5404

Closed monsieurtanuki closed 1 month ago

monsieurtanuki commented 3 months ago

What

Improvements about price adding:

Bug fix:

Screenshot

unique barcode no "add product" button at start remember my choice
Screenshot_1718730706 Screenshot_1718730671 Screenshot_1718730619

Part of

Impacted files

monsieurtanuki commented 3 months ago

Thank you @g123k for your comments, it made me go back to the flutter docs and realize that I forgot the dispose calls. I've just added them in the latest push.

As for your latest comments, I guess you've reached the limits of my understanding: I cannot picture in which language a number like 5 wouldn't be understood (OK Japanese people also use but they do understand 5), and a TextEditingController won't notify an object that doesn't exist yet.

Feel free to amend this PR or to close it.

Meanwhile, I convert it to "Draft".

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.

Project coverage is 6.94%. Comparing base (4d9c7fc) to head (5fb06b8). Report is 284 commits behind head on develop.

Files Patch % Lines
...pp/lib/pages/prices/price_product_search_page.dart 0.00% 35 Missing :warning:
...smooth_app/lib/pages/prices/price_amount_card.dart 0.00% 28 Missing :warning:
...h_app/lib/pages/prices/product_price_add_page.dart 0.00% 22 Missing :warning:
...kages/smooth_app/lib/pages/prices/price_model.dart 0.00% 4 Missing :warning:
...mooth_app/lib/pages/prices/price_amount_model.dart 0.00% 3 Missing :warning:
...mooth_app/lib/pages/prices/price_amount_field.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5404 +/- ## ========================================== - Coverage 9.54% 6.94% -2.61% ========================================== Files 325 399 +74 Lines 16411 21203 +4792 ========================================== - Hits 1567 1473 -94 - Misses 14844 19730 +4886 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

monsieurtanuki commented 1 month ago

Closing as stale.