Closed monsieurtanuki closed 1 month ago
Thank you @g123k for your comments, it made me go back to the flutter docs and realize that I forgot the dispose
calls.
I've just added them in the latest push.
As for your latest comments, I guess you've reached the limits of my understanding: I cannot picture in which language a number like 5
wouldn't be understood (OK Japanese people also use 五
but they do understand 5
), and a TextEditingController
won't notify an object that doesn't exist yet.
Feel free to amend this PR or to close it.
Meanwhile, I convert it to "Draft".
Attention: Patch coverage is 0%
with 93 lines
in your changes missing coverage. Please review.
Project coverage is 6.94%. Comparing base (
4d9c7fc
) to head (5fb06b8
). Report is 284 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing as stale.
What
Improvements about price adding:
Bug fix:
key
issue)Screenshot
Part of
5403
Impacted files
app_en.arb
: added a "remember my choice" and a "barcode already there" labelsapp_fr.arb
: added a "remember my choice" and a "barcode already there" labelsprice_amount_card.dart
: now using a focus node and akey
; stronger resilienceprice_amount_field.dart
: now using a focus nodeprice_amount_model.dart
: minor refactoringprice_model.dart
: newgetBarcodes
methodprice_product_search_page.dart
: now managing a list of existing barcodes; now storing at session level the answer of the "server look-up?" questionproduct_price_add_page.dart
: now manages a focus on the latest added product, and keys for item deletion; not displaying the "add product" button if irrelevant