openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
800 stars 275 forks source link

Add support for showing producer provided and protected fields #5430

Open teolemon opened 3 months ago

teolemon commented 3 months ago

Problem

Mockups

image

Part of

VaiTon commented 2 months ago

Related forum post: https://forum.openfoodfacts.org/t/auchan-tourteau-fromage-invalid-serving-size/613/4

M123-dev commented 2 months ago

Waiting for: https://github.com/openfoodfacts/openfoodfacts-dart/issues/956

monsieurtanuki commented 1 month ago
I don't know how we are supposed to display the "owner fields". current display display with "owner locked" fields
Screenshot_1723565488 Screenshot_1723565436
teolemon commented 1 month ago
monsieurtanuki commented 1 month ago

something we've never done is a replicate the product edit history you have at the bottom of the product page in the web version.

That would definitely deserve a separate issue. Plus a lot of additional code in off-dart (specifically for "product image for version x"). That would be for hard-core users, that have an interest in previous versions.

in the web the product owner is displayed in a warning tooltip (some of the database product has been provided by the producer blah)

Instead of the lock icon we could use an info icon, with an info dialog.

I would believe that all of this should be less prominent than on the web version and possibly at the bottom of the page or in a special tab if we follow the proof of concept design.

I thought the point was to say: that specific field cannot be changed as it is provided by the producer. If we display a generic message and let the users (try to) change the values regardless, we'll still have the not-so-funny "background tasks do not work" complaints.