openfoodfacts / smooth-app

The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
742 stars 260 forks source link

Do we check that if some prices are empty when adding several prices in bulk ? #5435

Open teolemon opened 1 week ago

teolemon commented 1 week ago

Problem

Do we check that if some prices are empty when adding several prices in bulk ? @monsieurtanuki

monsieurtanuki commented 1 week ago

Do we check that if some prices are empty when adding several prices in bulk ?

We certainly do: the paid prices are mandatory - while the not discounted prices are optional. That means that we couldn't even create the background task with null prices. There's a check when we press the "send prices!" button, but in that particular case it's a form validation check. That means that for problematic price text fields there will be a red subtitle saying: "this price is mandatory!". Which may not be very explicit if it's price number 2 and we are at price number 9: we would have to scroll to the top to see what's wrong. UI/UX improvements probably needed here.