search

openfoodfacts / smooth-app

The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
742 stars 260 forks source link

chore: Allow `LaunchUrlHelper` to follow deep links #5450

Closed g123k closed 5 days ago

g123k commented 5 days ago

Hi everyone,

As is, the url_launcher dependency ignores deep links. To prevent this from happening (and avoid breaking things), there is now a second method redirecting to GoRouter

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (05b4e9e). Report is 232 commits behind head on develop.

Files Patch % Lines
...ages/smooth_app/lib/helpers/launch_url_helper.dart 0.00% 7 Missing :warning:
...ib/pages/scan/carousel/main_card/scan_tagline.dart 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5450 +/- ## ========================================== - Coverage 9.54% 7.18% -2.37% ========================================== Files 325 391 +66 Lines 16411 20388 +3977 ========================================== - Hits 1567 1464 -103 - Misses 14844 18924 +4080 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.