Missing birthday cake for new products

[monsieurtanuki]

What

• We used to display a birthday cake for new products, in order to suggest excitement I guess.
• The birthday cake isn't displayed anymore, and there are error logs.

Steps to reproduce the behavior

1. Go to the app
2. Search for a very unusual barcode like 123123123123
3. As the product doesn't exist, you'll see a "Hey, it's a new product!" dialog.
4. In this dialog you don't see a birthday cake, and logs say that the birthday cake is missing

Expected behavior

• A birthday cake
• or no birthday cake and no error logs
• The integration of OxF demands other improvements, like the selection of the product type, but that's another story.

Screenshot/Mockup/Before-After

Additional context

E/flutter ( 5795): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Unable to load asset: "assets/onboarding/birthday-cake.svg".
E/flutter ( 5795): The asset does not exist or has empty data.
E/flutter ( 5795): #0      PlatformAssetBundle.load.<anonymous closure> (package:flutter/src/services/asset_bundle.dart:327:9)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #1      SvgLoader._load.<anonymous closure> (package:flutter_svg/src/loaders.dart:153:41)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #2      _VectorGraphicWidgetState._loadPicture.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:355:40)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #3      _VectorGraphicWidgetState._loadPicture.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:369:13)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #4      _VectorGraphicWidgetState._loadAssetBytes.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:402:45)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795):

[thedevyash]

pls assign this issue to me

[monsieurtanuki]

Hi @thedevyash! Please don't provide any random birthday cake. We used to have one. I guess you'll find it in the code history.

[thedevyash]

this works?

[monsieurtanuki]

this works?

I don't know: where did you find this .svg file?

[thedevyash]

this works?

I don't know: where did you find this .svg file?

Found this in an old version inside assets/onboarding/

[monsieurtanuki]

Ok then, you're ready for PR!