openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
861 stars 286 forks source link

feat: 5621 - "road to scores" label now depends on OxF #5772

Closed monsieurtanuki closed 3 weeks ago

monsieurtanuki commented 3 weeks ago

What

Fixes bug(s)

Impacted files

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 7.05%. Comparing base (4d9c7fc) to head (94ab8c4). Report is 410 commits behind head on develop.

Files with missing lines Patch % Lines
packages/smooth_app/lib/query/product_query.dart 0.00% 8 Missing :warning:
...app/lib/pages/product/product_incomplete_card.dart 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5772 +/- ## ========================================== - Coverage 9.54% 7.05% -2.49% ========================================== Files 325 409 +84 Lines 16411 21969 +5558 ========================================== - Hits 1567 1551 -16 - Misses 14844 20418 +5574 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

monsieurtanuki commented 3 weeks ago

Thank you @teolemon for your review!

Typically not an easy issue to test as it would be very simple to create a dumb product from scratch in test env, and wait until the message appears. We cannot do that because there's no beauty test env and searching on that server (in order not to find the product) causes an error. We should somehow skip the beauty test env, at least via dev mode. What do you think of that?