openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
860 stars 286 forks source link

feat: Product page with the status bar from the POC #5808

Closed g123k closed 2 weeks ago

g123k commented 2 weeks ago

Hi everyone!

One more feature from the POC: the status bar containing the compatibility score.

🎥 Here's a demo: https://github.com/user-attachments/assets/572374c0-4524-4cdb-ad01-70d9cbea7fe9

FYI, this implementation is temporary to let us revamp the onboarding (by removing the food prefs). Normally, it requires the Sliver mechanism, hence, the non-blocking AppBar on scroll (you have to test to understand this)

Also, I wonder if we shouldn't change a bit the compatibility colors… otherwise, there is never some red. For instance, does 50% deserve a green?

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 2.97030% with 196 lines in your changes missing coverage. Please review.

Project coverage is 7.07%. Comparing base (4d9c7fc) to head (4fc4e84). Report is 439 commits behind head on develop.

Files with missing lines Patch % Lines
...pages/product/product_page/new_product_header.dart 2.88% 101 Missing :warning:
...b/pages/product/product_page/new_product_page.dart 0.00% 67 Missing :warning:
..._app/lib/helpers/product_compatibility_helper.dart 0.00% 9 Missing :warning:
...pages/product/product_page/new_product_footer.dart 0.00% 6 Missing :warning:
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% 5 Missing :warning:
...ges/smooth_app/lib/themes/smooth_theme_colors.dart 0.00% 4 Missing :warning:
...cards/product_cards/smooth_product_card_found.dart 0.00% 1 Missing :warning:
...mooth_app/lib/pages/personalized_ranking_page.dart 0.00% 1 Missing :warning:
..._app/lib/pages/product/compare_products3_page.dart 0.00% 1 Missing :warning:
...ib/pages/product/product_compatibility_header.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5808 +/- ## ========================================== - Coverage 9.54% 7.07% -2.48% ========================================== Files 325 412 +87 Lines 16411 22345 +5934 ========================================== + Hits 1567 1580 +13 - Misses 14844 20765 +5921 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

g123k commented 2 weeks ago

I was thinking of turning the circular numerical indicator into a "Road to Scores" shortcut when it is the case @g123k Otherwise, LGTM

We can do it now, with this integration. But with the new onboarding, instead we will have a "Personalize your score" (or something like) at the top of the screen.