openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
860 stars 286 forks source link

feat: Allow to reorder the action bar #5826

Closed g123k closed 2 weeks ago

g123k commented 2 weeks ago

Hi everyone!

This PR contains multiple changes:

🎥 Demo: https://github.com/user-attachments/assets/fa7ff19a-54ae-48e3-8bed-494cb07e82d1

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 1.92593% with 662 lines in your changes missing coverage. Please review.

Project coverage is 6.92%. Comparing base (4d9c7fc) to head (b0dee37). Report is 465 commits behind head on develop.

Files with missing lines Patch % Lines
...oduct_page/footer/new_product_footer_settings.dart 2.10% 279 Missing :warning:
...kages/smooth_app/lib/widgets/smooth_list_diff.dart 0.00% 121 Missing :warning:
...roduct/product_page/footer/new_product_footer.dart 1.73% 113 Missing :warning:
...roduct_page/footer/new_product_footer_compare.dart 2.32% 42 Missing :warning:
...oth_app/lib/pages/product/product_list_helper.dart 0.00% 17 Missing :warning:
...duct_page/footer/new_product_footer_add_price.dart 5.55% 17 Missing :warning:
.../product_page/footer/new_product_footer_share.dart 5.55% 17 Missing :warning:
...t/product_page/footer/new_product_footer_edit.dart 6.25% 15 Missing :warning:
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 14 Missing :warning:
...t_page/footer/new_product_footer_add_to_lists.dart 7.69% 12 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5826 +/- ## ========================================== - Coverage 9.54% 6.92% -2.63% ========================================== Files 325 422 +97 Lines 16411 23229 +6818 ========================================== + Hits 1567 1609 +42 - Misses 14844 21620 +6776 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teolemon commented 2 weeks ago

@g123k merge conflict

g123k commented 2 weeks ago

@g123k merge conflict

Should be OK now 👌

teolemon commented 2 weeks ago

arg, I should have done the crowdin merge last @g123k 🫨

teolemon commented 2 weeks ago

Thanks @g123k and sorry for the snafu