Closed g123k closed 4 days ago
Attention: Patch coverage is 0.89286%
with 444 lines
in your changes missing coverage. Please review.
Project coverage is 6.78%. Comparing base (
4d9c7fc
) to head (154910c
). Report is 481 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- I'd be tempted to have a secret gesture (Long press on the outdated image) or button to directly jump to the camera to refresh the current photo
For this one, I first need to change the product addition flow. Blocked by #5857
- We will probably have to tweak this widget to have an inline equivalent to the tab system (drop-down, little list of available languages, accordion of available languages) when we insert it into the photos tab. By then anyway, the language shown in the photos tab will be probably good for 99% of viewers.
An alternative would be to show a different layout on the product page, with only the "best pictures". However, if photos are missing, a message will be displayed. The idea would be to keep the advanced view in editing and a simplified view on the product page.
@teolemon I have a doubt about my implementation. It will always open the default language (the current issue with missing photos will disappear).
Is it what we want? Or should I open the tab containing the user language?
If and only if it has photos already. Otherwise, it's just a tap away to add photos. Let's avoid wrong incentives.
Ok, so I let this PR as is
Hi everyone!
Here's the final touch for the photo gallery. 🎥 Video: https://github.com/user-attachments/assets/8308da52-1577-492d-afe6-4d1e35f48e20
There are now tabs for languages on top of the screen:  
And the action button is not a FAB anymore, but a footer button: