openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
855 stars 283 forks source link

feat: 5855 - no visible product type filter by default #5878

Closed monsieurtanuki closed 3 days ago

monsieurtanuki commented 4 days ago

What

Screenshots

switch off (default) switch on
Screenshot_1731940664 Screenshot_1731941946
Screenshot_1731941901 Screenshot_1731941961
Screenshot_1731941932 Screenshot_1731941973

Fixes bug(s)

Impacted files

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 6.74%. Comparing base (4d9c7fc) to head (cf55dc5). Report is 485 commits behind head on develop.

Files with missing lines Patch % Lines
...b/pages/preferences/user_preferences_settings.dart 0.00% 7 Missing :warning:
.../lib/data_models/preferences/user_preferences.dart 0.00% 5 Missing :warning:
...th_app/lib/pages/search/search_product_helper.dart 0.00% 5 Missing :warning:
packages/smooth_app/lib/database/dao_product.dart 0.00% 1 Missing :warning:
...pp/lib/pages/product/common/product_refresher.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5878 +/- ## ========================================== - Coverage 9.54% 6.74% -2.81% ========================================== Files 325 433 +108 Lines 16411 23984 +7573 ========================================== + Hits 1567 1617 +50 - Misses 14844 22367 +7523 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

g123k commented 4 days ago

Generally speaking, seems OK.

However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)

monsieurtanuki commented 4 days ago

Generally speaking, seems OK.

However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)

Understood, but I'm currently visiting family in Italy and I won't be able to change anything before Friday.

g123k commented 4 days ago

Generally speaking, seems OK. However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)

Understood, but I'm currently visiting family in Italy and I won't be able to change anything before Friday.

Ok, no pb, I will change it directly in your PR. Enjoy your time in Italy 🤌 !

g123k commented 3 days ago

The filter is now in the App settings:

Screenshot 2024-11-19 at 00 20 18
monsieurtanuki commented 3 days ago

The filter is now in the App settings

Good. I guess we're all set then.

teolemon commented 3 days ago

Thanks @monsieurtanuki @g123k 📸🧴🐾

monsieurtanuki commented 3 days ago

Thank you @g123k @teolemon for your reviews, feedbacks and code!