Closed monsieurtanuki closed 3 days ago
Attention: Patch coverage is 0%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 6.74%. Comparing base (
4d9c7fc
) to head (cf55dc5
). Report is 485 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Generally speaking, seems OK.
However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)
Generally speaking, seems OK.
However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)
Understood, but I'm currently visiting family in Italy and I won't be able to change anything before Friday.
Generally speaking, seems OK. However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). Also, I would maybe change the setting to enable it (not the other way around)
Understood, but I'm currently visiting family in Italy and I won't be able to change anything before Friday.
Ok, no pb, I will change it directly in your PR. Enjoy your time in Italy 🤌 !
The filter is now in the App settings:
The filter is now in the App settings
Good. I guess we're all set then.
Thanks @monsieurtanuki @g123k 📸🧴🐾
Thank you @g123k @teolemon for your reviews, feedbacks and code!
What
Screenshots
Fixes bug(s)
Impacted files
background_task_price.dart
: minor unrelated fix due to off-dart 3.17.0dao_product.dart
: we overwrite the products product_type with the server product type only if nullproduct_query.dart
: now retrieving product_type field in products found on a serverproduct_refresher.dart
: unrelated minor refactoringpubspec.lock
: wtfpubspec.yaml
: upgraded off-dart to 3.17.0search_product_helper.dart
: visible/invisible product type filter, by default invisible and working on fooduser_preferences_dev_mode.dart
: on/off switch for visible product type filter, off by default