Refresh issue on "basic information" screen

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart

https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo

Apache License 2.0

855 stars 283 forks source link

Refresh issue on "basic information" screen #5889

Open raphael0202 opened 2 days ago

raphael0202 commented 2 days ago

What

On this product, I edited the missing "quantity" field, by clicking on the "complete basic information" button. Even after refreshing the product, the button still appears even if all basic info fields are completed.

Steps to reproduce the behavior

Go to product 3760295171089
Click on "complete basic information"
See error

I'm using internal release.

Screenshot_2024-11-20-20-01-16-74_1d77bc0953a7db61673d4bea4cd4be8a.jpg

Screenshot_2024-11-20-20-01-21-84_1d77bc0953a7db61673d4bea4cd4be8a.jpg

monsieurtanuki commented 1 day ago

@raphael0202 That button comes from an outdated server recommandation:

you see an up-to-date local quantity
the quantity will be sent to the server and we'll download the refreshed product
meanwhile we display that button

A solution would be to ignore altogether that server button and to implement locally an "are the details all there?" test.

g123k commented 1 day ago

I think this issue is linked to https://github.com/openfoodfacts/smooth-app/issues/5864 Could you try again when the API is fixed?

monsieurtanuki commented 1 day ago

We always have this issue. https://github.com/openfoodfacts/smooth-app/issues/5864 just makes it more obvious.