openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
863 stars 286 forks source link

feat: "Use photo as" available directly in the gallery (+ a fix) #5916

Closed g123k closed 5 days ago

g123k commented 5 days ago

Hi everyone!

To reduce the number of clicks, the action to "use a photo as" is directly available in the gallery: https://github.com/user-attachments/assets/fcd97d75-4bcd-4359-bebb-e13ff9e0a2e1

There was also a funny issue with the "Add photo" button which was scrolling when the tabs were scrolling (obviously fixed): https://github.com/user-attachments/assets/605d4ea6-e477-49ee-b51e-195ddc934bfe

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 6.60%. Comparing base (4d9c7fc) to head (9b9d8c8). Report is 504 commits behind head on develop.

Files with missing lines Patch % Lines
..._app/lib/pages/image/product_image_other_page.dart 0.00% 35 Missing :warning:
.../pages/image/product_image_gallery_other_view.dart 0.00% 5 Missing :warning:
...oduct/gallery_view/product_image_gallery_view.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5916 +/- ## ========================================== - Coverage 9.54% 6.60% -2.95% ========================================== Files 325 436 +111 Lines 16411 24543 +8132 ========================================== + Hits 1567 1621 +54 - Misses 14844 22922 +8078 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

teolemon commented 5 days ago

@g123k why is it so saving local version for server side cropping ?

Screenshot_20241124-095106.png

g123k commented 5 days ago

I've plugged the feature to the existing one. Kid you want to change it, we have to change it in the whole app