"ABC-abc-1234" barcode drives the app in a loop

[jasmeet0817]

What

• non-stop loading spinner after scanning a product that doens't exist in DB

  Part of

  Screenshot

  

[monsieurtanuki]

• Hi @jasmeet0817! Supposed to be fixed by https://github.com/openfoodfacts/smooth-app/pull/630

[jasmeet0817]

Ah perfect, thank you

[monsieurtanuki]

• @jasmeet0817 If your tests with #630 are OK, would you please close this issue?

[jasmeet0817]

Hey, update on this one, it works for all devices except smaller ones (and perhaps might not work for some languages) so I'm trying another approach but it's really difficult to get this one right, I'm currently working with Greg from the flutter team for it

[monsieurtanuki]

Let's be more precise:

1. you actually scanned a barcode (you did not type in a string)
2. and this barcode was not found on the server database
3. and you saw an endless spinner

Is that correct?

[teolemon]

i believe this one is fixed.

[teolemon]

Can still reproduce with this barcode

[M123-dev]

What does the server respond for this barcode

[teolemon]

https://world.openfoodfacts.org/api/v0/product/ABC-abc-1234.json

[teolemon]

assuming we send this request

[teolemon]

I can still reproduce

[UgoKo-Rubeast]

I have checked codes and found response from backend is certainly received. But the following widget rebuilding is not working. I have confirmed scanning of an another product existing in DB works well. Perhaps the loop is due to a bug in provider library? https://github.com/openfoodfacts/smooth-app/blob/631b3675afc6205382a74c3de530fcea7cb0771c/packages/smooth_app/lib/data_models/continuous_scan_model.dart#L87-L93

[teolemon]

Still here

[M123-dev]

Still here, but changed visually (the flickering is because of me scrolling back but the scanner scanning it again

https://user-images.githubusercontent.com/39344769/209358894-7d588ef4-3333-4f63-8372-c03dcbcb4c44.mp4

[teolemon]

Still here, failing silently

[monsieurtanuki]

Looks like it's fixed now.