Use attribute setting_name (e.g. "Low salt") instead of name ("Salt") in preferences menu

[stephanegigandet]

What

• For preferences, the app displays the attribute name (e.g. "Salt") in the preferences menu.
• There is a special setting_name field "Low salt" that makes more sense for setting preferences. (the fields are loaded from https://world.openfoodfacts.org/api/v2/attribute_groups )
• Otherwise we have things like "Sugars - Mandatory" which makes it sound it's mandatory to have sugars...

Part of

• 506

Screenshots

on the app

on the website

[stephanegigandet]

Another option is to change the label from "Mandatory" to "Very important", which would be less confusing.

[monsieurtanuki]

@stephanegigandet I understand your point. Your "another option" is easier to implement - does it look good?

Before:

After:

[monsieurtanuki]

OK it fits on the screen. There's still confusion with the importance levels, compared to the website:

• not important // ok
• important // ok
• very important // removed from smoothie because 3 levels is easier to understand
• mandatory // will still be mandatory, but the label will be "very important"

What if we used settingName and kept mandatory mandatory?

[teolemon]

Mandatory should remain mandatory, for allergens

[monsieurtanuki]

Then it will be the latest option, with longer attribute labels. Doesn't look very good though, many labels are on 2 and even 3 lines. The importance button with label is too big.

A suggestion:

[stephanegigandet]

Then it will be the latest option, with longer attribute labels. Doesn't look very good though, many labels are on 2 and even 3 lines.

I like it with smaller text indeed (and long attribute labels), the current text is way too big (on my phone at least).

[cli1005]

I suppose that this issue only takes care of the text, since the button is too complicated to manage without UI/UX design ( according to issue #1301)... We've made a final decision? We replace all names by settingNames? or we might display both if name and settingName does not have the same value as following?

[teolemon]

Here's a temporary solution. It takes more vertical space, but it's text safe, allows for explanatory tooltips, and using long wordings (e.g. "Low salt") instead of name ("Salt")

[M123-dev]

Not really satisfyed with this solution altough it's just temporary

[cli1005]

According to a discussion made with @teolemon, we will apply the solution proposed by @monsieurtanuki (https://github.com/openfoodfacts/smooth-app/issues/890#issuecomment-1007589240) as a temporary solution while waiting for the final UI/UX design:

• attribute value: name --> settingName
• text style : headline4 --> bodyMedium
• kept mandatory mandatory