The onboarding is half-french / half english

[teolemon]

What

• The onboarding is half-french / half english.

  Potential causes

  • My understanding is that it's because we're loading the local example product in English.
  • Are we already loading the various local products from the API @stephanegigandet designed ?
  • Does this API actually send back local products in the right language ?
  • Do we change the langcode properly while calling it (we should at least receive most of the response in English for the French product)

    Part of

• 561

  Screenshots

• 
• 

[monsieurtanuki]

cf. https://github.com/openfoodfacts/smooth-app/issues/41#issuecomment-841797727

The very first init of the app, for importance preferences we'll use the English version from the asset folder (we cannot store all languages in the assets), while async'ly downloading the "French version" and refreshing when done. Without internet connection, we're stuck with the English version. With internet connection, we probably should wait until that meta-data is downloaded.

Suggestion: make it explicit in the onboarding that we need to init the app using internet (additional "localized init" phase?), and in that internet/init phase we could download the sample product and the localized metadata.

That being said, I'm not sure if what I've just said applies exactly with that specific issue. But it should be dealt with, too.

[monsieurtanuki]

Suggestion: make it explicit in the onboarding that we need to init the app using internet (additional "localized init" phase?), and in that internet/init phase we could download the sample product and the localized metadata.

@teolemon ping: either we have an app with potentially default values in English, or we take time to download localized data. And if we take time and use the internet it's probably better to tell so to the user, isn't it?

[teolemon]

• We should aim at a localized experience with potentially a little circular spinner "Retrieving a product that's perfect for you from the internet"
• @stephanegigandet "the perfect for you" product is actually weird on some specific subcases, and should include all possible allergens, and change color on non standard situations

[jasmeet0817]

So I talked to Stephane about this last week, this was the plan

• Query for the product from BE with barcode=example (we can already do this now).
• If network fails default to the English version as we do now.

[monsieurtanuki]

Working on the subject, and so far so good...

[monsieurtanuki]

Et voilà:

I rely on the 'example' barcode. 90% of the job is done. Still some refactoring to do, and coding on off-dart.

[monsieurtanuki]

Fixed by #986.