Closed filipefurtad0 closed 1 year ago
Another occurrence here.
Just failed on master again:
Ran this one locally over a 100x, but never seen it fail.
I see no reason why capybara does not wait for the modal to appear... So I guess our best bet is adding the retry
option here?
Looking at the screenshot generated by Capybara and available here:
Seems like we are in spanish ;)
Hum, thanks - good point @jibees - and my bad actually, as this can be seen in the error message :+1: Food for thought. Happy to investigate it.
This part of the code seems to be very edgy, old as it use angular template (don't know why: any good reason or old code?)
engines/web/app/views/web/angular_templates/cookies_policy.html.haml
engines/web/app/assets/javascripts/web/cookies_policy/cookies_policy_modal_service.js.coffee
engines/web/app/assets/javascripts/web/cookies_policy/cookies_policy_modal_controller.js.coffee
and
engines/web/app/assets/javascripts/web/cookies_policy/cookies_policy_modal_directive.js.coffee
old as it use angular template (don't know why: any good reason or old code?)
No idea :shrug:
Seems like I could reproduce on local as well:
My interface is in German, while my browser is configured in French as first language.
Will open an issue.
I've open a draft PR that managed to reproduce the error: https://github.com/openfoodfoundation/openfoodnetwork/pull/10437
Now, we probably should solve it (I don't know the severity of this one, is this really annoying?)
Yes, annoying. Another fail: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/4315184265/jobs/7529208778
I just had another fail in master. I'm taking this one.
What we should change and why (this is tech debt)
Context
https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/3950860801/jobs/6763967077
Impact and timeline