[BOM] Sorting doesn't consider orders from other pages

[dacook]

Description

Currently, clicking on a column heading will sort just the data in the current page. Data from other pages is not included in the sorting. Users would expect that to sort items from all pages (that is, perform a new query with sorting), like the /admin/orders/ screen.

Expected Behavior

Clicking on a column header should sort items from all pages (that is, perform a new query with sorting), like the /admin/orders/ screen.

Actual Behaviour

Clicking on a column heading will sort just the data in the current page.

Steps to Reproduce

Go to /admin/orders/bulk_management and select conditions for more than 15 orders Click a column header

Animated Gif/Screenshot

Workaround

Adjust pagination or filters to ensure all data is on one screen before sorting

Severity

I would call it "broken" because I believe it breaks user intuition.

bug-s3: a feature is broken but there is a workaround

Possible Fix

Behave the same as the /admin/orders screen.

[dacook]

Raised from: https://github.com/openfoodfoundation/openfoodnetwork/pull/10653

[audez]

duplicate of https://github.com/openfoodfoundation/openfoodnetwork/issues/10571 ?

[drummer83]

Yes, it's a duplicate. Closing here.

[drummer83]

Reopening this one to cover the other columns and to make sorting over ALL pages (not just the elements on the current page). However we should not prioritize fixing it until it gets selected by an instance.

[abdellani]

Hi Is this page supposed to be reimplemented in stimulus reflex? if yes, maybe the one who will do that will take care of the sorting issue.

[dacook]

Good question, yes, this is already solved in the new products bulk edit screen. However that's not available yet, so I think this issue may need to stay open. But on considering that, I would certainly no prioritise this.