Release v4.3.4 Café au lait

mkllnk commented 1 year ago

Preparation on Thursday

[x] Merge pull requests in the Ready To Go column
[x] Include translations: tx pull --force
x. Look at previous releases for inspiration.
[x] Notify #instance-managers of user-facing changes.

Testing

x of the release commit and copy it below.
[x] Move this issue to Test Ready.
[x] Notify @testers in #testing.
[x] Test build: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master/builds/4367

Finish on Tuesday

[x] Publish and notify #global-community (this is automatically posted with a plugin)

[x] Deploy the new release to all managed instances.

Command line instructions

cd ofn-install
git pull
ansible-playbook --limit all-prod --extra-vars "git_version=vx.y.z" playbooks/deploy.yml

[x] Notify #instance-managers:

@instance_managers The new release has been deployed.
[x] Nudge next release manager

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

sigmundpetersen commented 1 year ago

Shouldn't we bump the minor version number on this if this is releasing Split Checkout for all?

RachL commented 1 year ago

This is ready to go :) https://docs.google.com/document/d/1CRnS_6vpUfPintK1W9oxSHSGHIsU2THbww17ALgGLps/edit#

For the version number I have no strong opinion. We can also bump the number when we remove completely the old code.

mkllnk commented 1 year ago

Shouldn't we bump the minor version number on this if this is releasing Split Checkout for all?

Good point, I forgot about that. The rules of bumping version numbers are not very clear for OFN though. This is what we've done in the past:

v4.3.0 This release introduce a new version of Rails (7.0)!
v4.2.0 breaking change around image storing.
v4.1.0 ???
v4.0.0 We're switching to Puma
v3.8.0 Rails 6.0
v3.7.0 Rails 5.2
v3.6.1 Rails 5.0
v3.5.0 this release requires various bits of configuration from ofn-install so provisioning beforehand is mandatory.
v3.4.0 ???
v3.3.0 need to regenerate some of their images, as we are now using a new size.
...
v3.0.0 major upgrades for two of our core dependencies, bringing us to Spree 2.1 and Rails 4.0
v2.0.0 upgrade from Spree 1 to Spree 2

It looks like we have been using the version numbers for technical changes which are not backwards compatible like Rails upgrades or require provisioning with ofn-install. The split checkout is completely reversible and doesn't require any additional sysadmin action. Version numbers are not necessarily communicated to users.

I'll keep the patch version number.

openfoodfoundation / openfoodnetwork