openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.12k stars 724 forks source link

[Flaky] rspec ./spec/system/admin/order_cycles/simple_spec.rb:753 #10856

Closed drummer83 closed 1 year ago

drummer83 commented 1 year ago

What we should change and why (this is tech debt)

Failures:

  1) 
    As an administrator
    I want to manage simple order cycles
 modify the minute of a order cycle with the keyboard, check that the modifications are taken into account
     Failure/Error:
       within "#save-bar" do
         expect(page).to have_content "You have unsaved changes"
       end

     Capybara::ElementNotFound:
       Unable to find visible css "#save-bar"

     [Screenshot Image]: /home/runner/work/openfoodnetwork/openfoodnetwork/tmp/capybara/screenshots/failures_r_spec_example_groups_as_an_administrator_i_want_to_manage_simple_order_cycles_modify_the_minute_of_a_order_cycle_with_the_keyboard__check_that_the_modifications_are_taken_into_account_541.png

     # ./spec/system/admin/order_cycles/simple_spec.rb:764:in `block (2 levels) in <main>'
     # ./spec/system/support/cuprite_setup.rb:41:in `block (2 levels) in <top (required)>'

Finished in 3 minutes 44.6 seconds
51 examples, 1 failure, 3 pending

Failed examples:

rspec ./spec/system/admin/order_cycles/simple_spec.rb:753 # 
    As an administrator
    I want to manage simple order cycles
 modify the minute of a order cycle with the keyboard, check that the modifications are taken into account
I, [2023-05-17T13:03:42.105081 #2928]  INFO -- : [knapsack_pro] To retry all the tests assigned to this CI node, please run the following command on your machine:
I, [2023-05-17T13:03:42.105144 #2928]  INFO -- : [knapsack_pro] bundle exec rspec --format progress --default-path spec "spec/system/admin/order_cycles/simple_spec.rb" "spec/system/admin/enterprises/business_address_form_spec.rb" "spec/system/admin/tag_rules_spec.rb" "spec/system/admin/enterprise_roles_spec.rb" "spec/system/admin/enterprises/index_spec.rb" "spec/system/admin/reports/payments_report_spec.rb" "spec/system/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb" "spec/system/admin/authentication_spec.rb" "spec/system/admin/bulk_order_cancellation_spec.rb"
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/openfoodnetwork/openfoodnetwork/coverage. 7984 / 23278 LOC (34.3%) covered.
Error: Process completed with exit code 1.

Context

https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/5003473010/jobs/8964744221

Impact and timeline

sigmundpetersen commented 1 year ago

Is this the same as #10302 ?

filipefurtad0 commented 1 year ago

Yes, shall we rather close here then? The other issue has more context. It's also the same which failed on master now (re-triggering the build now)