[Admin, Orders] Tooltips on Ship order and Edit order missing, after payment capture - Githubissues

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.

https://www.openfoodnetwork.org

GNU Affero General Public License v3.0

1.1k stars 717 forks source link

[Admin, Orders] Tooltips on Ship order and Edit order missing, after payment capture #11131

Open filipefurtad0 opened 1 year ago

filipefurtad0 commented 1 year ago

Description

Follow-up from #10963 - while testing it, it was noticed that:

on the /admin/orders page
after capturing a payment (clicking the capture button)

the tooltips on Ship order and Edit order are missing.

Expected Behavior

Tooltips on Ship order and Edit order should be displayed, after capturing the payment.

Actual Behaviour

Tooltips on Ship order and Edit order are not displayed, after capturing the payment.

Steps to Reproduce

As a Hub (with some cash-paid orders):

Visit the /orders page
Capture a payment, for a given order
Notice, that after capturing the payment, the Ship tooltip is not displayed ❌
Notice, that after capturing the payment, the Edit tooltip is not displayed ❌

Animated Gif/Screenshot

Workaround

None needed.

Severity

bug-s5: we can live with it, only a few users impacted

Your Environment

Version used: v4.4
Browser name and version: Firefox 113
Operating System and version (desktop or mobile): Ubuntu 22.04

Possible Fix

dacook commented 2 months ago

I'm guessing this is because we update the button with CableReady (WebSocket) and it doesn't re-initialise the tooltip JS. We'd like to remove the CableReady implementation one day, but in the meantime perhaps a browser tooltip (title=) would be sufficient as a fallback.