Add search / filter parameters to DFC Enterprise Connector

[kirstenalarsen]

All Global work to be tracked in Clockify #11242 Discovery Endpoints - including testing, code review etc Aus devs to track in #11242 Task within Macdoch Regen Discovery

Description

Following here

We need to be able to request to READ specific results from the DFC Enterprise Connector so that we are not getting all the OFN Enterprises each time we use it, but just the ones we need. Suggested parameters include:

• [x] By Enterprise ID - standard show action
• [ ] By postcode, State, Country [can this be internationalised?]

Not Yet - TBC

• [ ] By facet/property ID or name (to be checked)
• [ ] By is-primary-producer (to be checked)
• [ ] By sells (to be checked)
• [ ] By name
• [ ] Created at / after
• [ ] Updated at / after

Please add suggested parameters in Sheet 'Enterprise Search/Filter Parameters] here or comment below and I'll update list above

@mkllnk needs to check-in with DFC / @RaggedStaff about DFC proposed approach to this as is not currently clear

Acceptance Criteria & Tests

• Read Enterprises using DFC Connector as JSON file using parameters to limit number of results

[mkllnk]

I discussed this with @RaggedStaff and @lecoqlibre. The main points were:

• The DFC doesn't contain any standard for filtering at the moment. It has to be done on the client side.
• Maxime is researching using defined Indexes on data exposing them through the API. This may become part of the DFC standard one day.
• Alternatively, query languages like SPARQL and GraphQL were discussed but, at this point, they are not easy to implement in a way that they give us a performance gain.

So... in the absence of a standard, we can just do what we want, right? The easiest would be to use the same techniques as in our other APIs. There we use ransack query parameters to filter on database level. The parameter names and values would be OFN-specific and represent our database models.

[mkllnk]

@rioug We simplified our first version of the discovery portal and won't need this feature at the moment. Maybe later.

[rioug]

I didn't really have time to look at this so no time lost here.

[kirstenalarsen]

@rioug I have moved this back into 'in scope' but just the next checkbox at this point - can you give me an estimate on allowing search by geography i.e. postcode, state/region, country?

[kirstenalarsen]

rough estimate: 2-3 days to implement ransack search and these three string parameters