openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.09k stars 709 forks source link

[Admin->Orders] Unify design of confirmation dialogs #11545

Open drummer83 opened 1 year ago

drummer83 commented 1 year ago

What is the need / problem?

The confirmation dialog on the orders list page for bulk actions is different than the confirmation dialog on other pages, e.g. for cancelling an order. There are at least five places where an order can be cancelled. Four of those have the same design but the one on the /orders page is different. All confirmations on the /orders page should be unified to match the design and the position on the screen.

Which type of users does this problem affect (and how many, if known)?

Potential solutions that will solve the problem

Reuse the existing design on /orders as well. This is valid for

Connected wishlist and discovery discussions

Additional context

  1. Actions dropdown in the orders list (design and position on screen needs adjustment :x:) image

  2. Cancel button on the edit order page (ok :heavy_check_mark:) image

  3. Action dropdown on the edit order page (ok :heavy_check_mark:) image

  4. Deleting the last line item of an order on the edit order page (ok :heavy_check_mark:) image

  5. Deleting the last line item of an order on bulk order management page (ok :heavy_check_mark:) image

RachL commented 10 months ago

@mariocarabotta going through the general backlog with the team, we thought JB could handle this one within the admin v3 overview. Do you have already somewhere a design for confirmation modals? The current one we use comes from a design contributor, see https://github.com/openfoodfoundation/wishlist/issues/44#issuecomment-917722084

mariocarabotta commented 10 months ago

there is a new modal design for deleting products here. This will be implemented as part of [BUU] Delete a product or variant. Could it be an opportunity to pick up these 2 in parallel and see if it's possible to use a component from v3 in a v2 interface? @jibees don't hate me 🫣