[Inventory] Setting variants as hidden always hides them in outgoing exchange of OC, regardless of enterprise settings

[filipefurtad0]

Description

This looks like a regression from #11501.

An enterprise has the New products can be put into my shopfront (recommended) setting enabled, but inventory items are still not being displayed for selection; instead, the message introduced in #11501 is displayed in the outgoing exchange of the order cycle.

This is preventing coordinators from adding variants to order cycles, requiring for suppliers to additionally grant permissions to distributors: only permissions between supplier - coordinator AND distributor - coordinator should be necessary. Reported here.

Expected Behavior

As the order cycle coordinator, having the option the enterprise setting New products can be put into my shopfront (recommended) does not allow hidden inventory items to be added in the outgoing exchange of the order cycle.

Actual Behaviour

As per user guide, it is only when:

• an item is hidden in the inventory
• the enterprise setting is New products must be added to my inventory before they can be added to my shopfront that variants cannot be selected in the outgoing exchange of the order cycle, and display the warning introduced in this PR.

Steps to Reproduce

The easiest way to reproduce the bug is with one enterprise, acting as coordinator, supplier and distributor of an order cycle:

1. Add a variant to the inventory.
2. Set it as hidden.
3. On the dashboard, enable the preference New products can be put into my shopfront (recommended)
4. Create an order cycle.
5. Add the variant to the incoming exchange
6. Try to add it to the outgoing exchange -> see the warning No variant available for this product (hidden via inventory settings).

Animated Gif/Screenshot

Workaround

On the inventory, toggle the column hidden; click Add. The variant should be to be selected again, on the outgoing exchange of the order cycle.

Severity

There is a workaround, so: bug-s3: a feature is broken but there is a workaround

However:

• This looks like a regression.
• Seems to be taking plenty of manual input from support teams, for multi enterprise order cycles...

Your Environment

• Version used: v4.4.20
• Browser name and version: Firefox 119
• Operating System and version (desktop or mobile): Ubuntu 22.04

Possible Fix

[basilawwad]

Hi, I would like to work on this, can you assign it to me?

[sigmundpetersen]

Thank you @basilawwad , I'll assign you!

[RachL]

Hello @basilawwad I hope this message finds you well. Are you still planning to work on this issue? Let us know if you need more info!