search

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.09k stars 709 forks source link

[BOM] Shared resources checkbox is not working anymore #12099

Open RachL opened 5 months ago

RachL commented 5 months ago

Description

According to the user guide, we should be able to edit quantities of different variants of the same product thanks to this checkbox.

https://guide.openfoodnetwork.org/basic-features/orders/view-orders#the-shared-resource-checkbox

Now it's not showing up any differences.

Steps to Reproduce

  1. Log in as enterprise admin
  2. Got to /admin/orders/bulk_management
  3. Play with the checkbox

Workaround

Edit individually

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

cyrillefr commented 4 months ago

Hello @RachL ,

I have tried to figure out this issue. There is no JavaScript issue (no problem in console). From a newbie user (like me), I don't understand what should I do to the bulk edit. There are no hidden fields or anything that appear on clicking the checkbox; The doc seems a bit light on that.

So I searched when the code was implemented at first. I have found it here (dates back from 2014): https://github.com/openfoodfoundation/openfoodnetwork/commit/cd1086ce051a2abffd5a8b201dea48b1e4e3131c#diff-70474db1fb8f4bf7ce9188f6ae70d72bdb31f5a1eb175cc6666e9a0e3d2af29b

I have looked at the tests and found no descriptive test that could enlighten me about that bulk editing. Hope I am not missing anything here.

Also I haven't found the corresponding Issue/PR to get some more insights.

Has this feature ever worked ?

RachL commented 4 months ago

@cyrillefr thanks for that search!

Yes the person who did the screenshot for the user guide (in 2019) confirmed to me that it was working. If you see the screenshot, I believe tomatoes: 3kg and tomatoes: 1kg are showing up because of the checkbox

bomtomshared

otherwise, to end up with a view filtered on a product you need to use the search or click on the name. But you would only have one of the variant, not both. Does it make sense?

@tschumilas @kirstenalarsen maybe you have more insights on how it was supposed to work?