openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.09k stars 710 forks source link

'Allow Data Sharing' url get stuck on 'Loading' for the Connected Apps #12425

Open karlafalk opened 2 months ago

karlafalk commented 2 months ago

Description

As part of the Waterloo Food Commons Project , we want to use Connected Apps to share enterprise profile information through n8n. We translated the url for Canada in Transifex, but when I test, the button changes to 'Loading' and continues to spin (for hours) and won't reset. Also, nothing was 'heard' in the n8n workflow it is connected to.

This has prevented us from triggering our workflow in n8n.

Expected Behavior

Clicking 'Allow Data Sharing' and should trigger the webhook in n8n that has the url the button has been translated to.

Actual Behaviour

Button changes to 'Loading' but gets stuck there and webhook isn't triggered.

Steps to Reproduce

  1. Copy Webhook url into Transifex
  2. Click 'Allow Data Sharing' in OFN Connected Apps
  3. Observe that it continues to say 'Loading'

Animated Gif/Screenshot

Screenshot 2024-04-30 at 2 13 05 PM

Workaround

None - can't trigger n8n webhook from OFN Connected Apps

Severity

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity -->

Your Environment

Possible Fix

filipefurtad0 commented 2 months ago

I found this bug to prevent the enterprise from connecting: once the infinite loader is seen, one cannot revert it. Refreshing the page / reloading did not improve the situation, i.e., I've found no workaround, as mentioned in the issue.

I think this would make it an S2. What do you think @openfoodfoundation/train-drivers-product-owners?

RachL commented 2 months ago

It's s2 material but it's not a core feature like checkout. So I would not fix this as part of core budget but instead fix it on funded feature that will use that page. does that make sense?

kirstenalarsen commented 1 month ago

if @David Thomas @.***> wants it fixed it could be done as part of waterloo project

On Fri, 24 May 2024 at 04:41, Rachel Arnould @.***> wrote:

It's s2 material but it's not a core feature like checkout. So I would not fix this as part of core budget but instead fix it on funded feature that will use that page. does that make sense?

— Reply to this email directly, view it on GitHub https://github.com/openfoodfoundation/openfoodnetwork/issues/12425#issuecomment-2127809930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWGXSGBANCUV3UYLWGH5UTZDYZ35AVCNFSM6AAAAABHBZSUHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHAYDSOJTGA . You are receiving this because you are on a team that was mentioned.Message ID: @.*** com>

David-OFN-CA commented 1 month ago

@karlafalk is this still an issue for us?

karlafalk commented 1 month ago

@David-OFN-CA No this isn't really a problem for us now. It only becomes a problem if the connected apps 'Allow Data Sharing' is connected to an incorrect url....if the url doesn't trigger anything it gets stuck 'loading' and the 'Allow Data Sharing' button has to be reset in the backend. But now that we we have it linked correctly to our n8n workflow it is not really an issue.