Allow return or line break in shipping / payment method description

[MrBowmanXD]

What? Why?

When setting up a shipping or payment method description, users are allowed to return to line or add line breaks in the admin side.

However this is not done is the shopfront where everything is only separated with a space. If description are long this can be quite ugly.

(copied from the issue)

• Closes #12365

Simply added the simple_format method in order to introduce line breaks or return in the shipping method description. (checkout/_details.html.haml: line98)

What should we test?

1. Login as admin, go to administration.
2. Add shipping method description with line breaks / return
3. Checkout and observe the same description in shopfront (access checkout details page threw shopping cart)

Note: Check security issues but simple_format sanitizes the html by default according to the documentation.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• [X ] User facing changes

The title of the pull request will be included in the release notes.

[MrBowmanXD]

Yes i can.

[MrBowmanXD]

I think we still need to test in order to check if the order of the methods is right, but in essence the solution might look like the above commit shows.

[MrBowmanXD]

We could make a test that simulates adding mailicious html to check if html_escape is working or it's redundant?

[rioug]

We could make a test that simulates adding mailicious html to check if html_escape is working or it's redundant?

It's not necessary, html_escape is part of Rails so it should be tested by Rails. If we can't trust Rails then we are in trouble :smile:

[MrBowmanXD]

Need to delete this last commit in github. This last commit introduces code that should not be there.

[MrBowmanXD]

It's good now, thanks for your help @MrBowmanXD 🙏

You last commit will be sorted out once we merge into master. Note for next time we prefer to rebase the branch instead of merging master.

Sorry for the late response but this last commit introduces code that should not be there. I can make another pull request if necessary.

[MrBowmanXD]

Had to remove the code according to #12443

[filipefurtad0]

Hey @MrBowmanXD ,

Thanks for another PR :muscle:

Before staging it, we can see the bug (left, admin section; right, shopfront):

After staging your PR we can see the line breaks are displayed correctly:

Awesome!! :tada: Merging.

[filipefurtad0]

Ohh, I just noticed there are some merge conflicts. Can you fix these @MrBowmanXD ?

Thanks!

[MrBowmanXD]

Check the shipping method description (in checkout details) and the payment method description (in checkout payment).