Fix RedundantPresenceValidationOnBelongs on two files

cyrillefr commented 2 weeks ago

After migration, all tests should pass and no rubocop offense should be raised. Run the rake file, to check it any corrupt data is present.

Note: only 1 migration file here because the null were already enforced at DB level for the variant_overrides table.

Changelog Category (reviewers may add a label for the release notes):

The title of the pull request will be included in the release notes.

cyrillefr commented 2 weeks ago

Hello @sigmundpetersen , @dacook

I would like a rerun of the checks due to some strange error that do not occur locally. Thanks :)

sigmundpetersen commented 2 weeks ago

I have re-run the spec a couple of times @cyrillefr but it seems consistent on CI

sigmundpetersen commented 2 weeks ago

Seems there's a fix in #12490, you could wait for that

sigmundpetersen commented 1 week ago

Hi @cyrillefr , you can rebase this now to get the fixes from #12490

cyrillefr commented 1 week ago

Hello @sigmundpetersen ,

Thank you.

dacook commented 1 week ago

Fixed conflict with GitHub UI. Apparently that does a merge, will consider a manual rebase next time..

openfoodfoundation / openfoodnetwork