[BUU] Remove SR from clear search button

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.

https://www.openfoodnetwork.org

GNU Affero General Public License v3.0

1.11k stars 718 forks source link

[BUU] Remove SR from clear search button #12551

Closed dacook closed 2 months ago

dacook commented 4 months ago

On the new Bulk Edit Products screen (/admin/products with feature toggle admin_style_v3): We want to remove the StimulusReflex action from the "Clear Search" button that appears when there are no search results.

See https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/views/admin/products_v3/_no_products.html.haml#L3
Also remove now-unused ProductsReflex

This is the last task which allows us to

Close https://github.com/openfoodfoundation/openfoodnetwork/issues/12331

Screenshot 2024-06-05 at 9 27 29 am

dacook commented 4 months ago

I think it will be pretty easy to change the link to load with the #products-content turbo-frame instead (ie with data-turbo-frame= "_self")

RachL commented 4 months ago

@sigmundpetersen not sure we want to fix this one as a priority after BUU release, that's why I've left it outside of the milestone.

@dacook can this one be a good first issue?

dacook commented 4 months ago

Yes, it's a small, clearly defined task, and would be a good intro to our use of Turbo .

wandji20 commented 3 months ago

Can I take this one?

dacook commented 3 months ago

Yes, thanks I've assigned you now.