openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.12k stars 724 forks source link

Bulk product import stalling at 66% when missing info #12973

Open amidaOFN opened 1 week ago

amidaOFN commented 1 week ago

Description

Bulk product upload function stalls with no error message when unit field is missing info in any row.

Expected Behavior

The upload should complete and then display error messages about what is wrong with the upload

Actual Behaviour

The upload does not complete and no error message is shown when there is a field left blank in the upload template. The upload stalls at 66% and does not progress or show an error message

Steps to Reproduce

Complete a bulk product upload template.

Leave the 'unit' field blank in one row.

Upload the csv - see that the upload stalls at 66%. Fixing this blank field allows the upload to complete and other errors are catalogued in the usual error message screen.

Workaround

Severity

bug-s2: a non-critical feature is broken, no workaround

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity -->

Your Environment

Happens across multiple environments

Possible Fix