openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.11k stars 719 forks source link

Possible missing exchange data if variant for line item calculator is deleted #3488

Open kristinalim opened 5 years ago

kristinalim commented 5 years ago

Description

Needs further investigation. Issue details to follow.

I found out that a variant's association with an OC, even a closed OC, is removed when the variant or product is deleted.

TODO

Expected Behavior

TODO

Actual Behaviour

TODO

Steps to Reproduce

TODO

Animated Gif/Screenshot

TODO

Context

Came across code implying this while doing code review.

Severity

bug-s2: a non-critical feature is broken, no workaround

sigmundpetersen commented 5 years ago

s2 or s3? 🙂

kristinalim commented 5 years ago

@sigmundpetersen I'm not sure yet. I'm currently investigating and will write more in the issue description, then will raise in the Slack channel.