Shipment state should not be based on hidden stock for on demand products - Githubissues

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.

https://www.openfoodnetwork.org

GNU Affero General Public License v3.0

1.11k stars 720 forks source link

Shipment state should not be based on hidden stock for on demand products #4306

Open RachL opened 5 years ago

RachL commented 5 years ago

Description

Currently on demand products which have a hidden stock at "0" will make all order appear with an "out-of-stock or "backordered" shipment state.

Steps to Reproduce

Order a product that is "on demand" and make sure the "hidden" stock value is at 0
Go to /orders?q[s]=completed_at+desc
See that your order has a shipment state as "out of stock" or "backordered"
Go back to the product, uncheck the on demand checkbox, add a positive value and save
Now your same order has a shipment state of "pending" or "ready"

Animated Gif/Screenshot

Step 1 :

After I've added some hidden stock on the product:

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

Version used: v2.5
Browser name and version: Firefox 69
Operating System and version (desktop or mobile): Both

luisramos0 commented 5 years ago

this is related to #4267

Matt-Yorkley commented 3 years ago

I don't think this issue is valid anymore, right? Is it still possible to get the order state to change to backordered?