openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.1k stars 714 forks source link

Orders and Fulfilments Report gives slug when producer and hub specified #4406

Closed lin-d-hop closed 1 year ago

lin-d-hop commented 4 years ago

Description

A user has reported that the Orders and Fulfilments report has changed in functionality. Thinking the report just wasn't working for them it disrupted their whole week, however we've now tracked down the issue.

Expected Behavior

A user who is a producer and a hub should be able to enter details into the producer and hub fields on the reports and get sensible data out. This is consistent with usage of OFN in other areas of the platform and allows for specific cases in which managers have multiple producers and hubs yet still want to be able to extract data for a single producer/hub.

This should work (currently slug): OFN not working

As should this (currently slug): OFN not working2

Actual Behaviour

when a user who is a hub and a producer inputs into BOTH the hub AND producer fields in the report they get a Slug 500 Error.

This does work: OFN working

Steps to Reproduce

  1. Go to Orders and Fulfilments report
  2. Enter a produce/hub in both the Producer and Hub field
  3. Wait for timeout then see slug

Workaround

If you only include the Producer/Hub in one field you don't get the error. This workaround is acceptable however inconsistent with usage of OFN in other parts of the platform. Not receiving an error message makes this confusing and troubling to the user.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

Possible Fix

lin-d-hop commented 4 years ago

Reports are a mess. This might be 20mins or might be 20 days. Not a papercut

kirstenalarsen commented 4 years ago

@lin-d-hop you think also too risky / confusing to set new developers on it? I suspect so . .

lin-d-hop commented 1 year ago

Closing. Can reopen if still an issue on new reports code.