Convert all erb templates from erb to haml

[luisramos0]

What we should change and why (this is tech debt)

There are a couple of templates in erb for example app/views/spree/admin/shared/_address_form.html.haml brought from spree that we can now convert to haml. This is related to openfoodfoundation/wishlist#343. Some of these template like _address_form. mentioned above contain js that needs to be converted and tested carefully.

Context

This came up in openfoodfoundation/openfoodnetwork#4513

Impact and timeline

This is not very urgent.

[luisramos0]

After spree_backend is removed, this is the list of erb files we need to convert:

• [ ] ./app/assets/javascripts/admin/util.js.erb
• [ ] ./app/assets/javascripts/admin/spree/image_settings.js.erb
• [ ] ./app/assets/javascripts/admin/spree/base.js.erb
• [ ] ./app/assets/javascripts/admin/spree/orders/variant_autocomplete.js.erb
• [ ] ./app/assets/javascripts/admin/spree/orders/shipments.js.erb
• [ ] ./app/assets/javascripts/admin/spree/spree-select2.js.erb
• [ ] ./app/assets/javascripts/admin/order_cycles/order_cycles.js.erb.coffee
• [ ] ./app/assets/javascripts/darkswarm/services/geo.js.erb.coffee
• [ ] ./app/views/spree/shared/_google_analytics.html.erb
• [ ] ./app/views/spree/admin/variants/_autocomplete.js.erb
• [ ] ./app/views/spree/admin/variants/new.js.erb
• [ ] ./app/views/spree/admin/states/new.js.erb
• [ ] ./app/views/spree/admin/properties/new.js.erb
• [ ] ./app/views/spree/admin/shared/_address_form.html.erb
• [ ] ./app/views/spree/admin/shared/_routes.html.erb
• [ ] ./app/views/spree/admin/shared/_translations.html.erb
• [ ] ./app/views/spree/admin/products/new.js.erb
• [ ] ./app/views/spree/admin/orders/customer_details/_autocomplete.js.erb
• [ ] ./app/views/spree/admin/taxonomies/_js_head.html.erb
• [ ] ./app/views/spree/user_mailer/signup_confirmation.en-GB.text.erb
• [ ] ./app/views/spree/user_mailer/reset_password_instructions.text.erb
• [ ] ./app/views/spree/user_mailer/confirmation_instructions.text.erb
• [ ] ./app/views/spree/checkout/payment/_check.html.erb
• [ ] ./lib/templates/erb/scaffold/_form.html.erb

Most of the code in these files is not erb anyway... Should be very easy to get this done. One idiom that appears in a few files and needs to be converted is this "escape_javascript":

$("#new_variant").html('<%= escape_javascript(render template: 'spree/admin/variants/new', formats: [:html], handlers: [:erb]) %>');