search

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.12k stars 723 forks source link

Products missing from producer's product list in the incoming exchange of the order cycle page #5820

Open RonellaG opened 4 years ago

RonellaG commented 4 years ago

Description

When a hub (Fawkner Commons-1441) went to setup a new order cycle some of the products from Saint David Dairy-826 were missing from the hub's inventory as well as the producer's product list.

Expected Behavior

All of Saint David Dairy's products should have appeared.

Actual Behaviour

Some of the products appeared in the create order cycle page (see screenshot) but 4 did not (non-homogenised milk, lite milk, creme fraiche and buttermilk). These products were no longer in the Producers product list even though they used to be.

Screen Shot 2020-07-24 at 2 47 29 pm

Steps to Reproduce

  1. Logged into Fawkner Commons account.
  2. Opened a test order cycle.
  3. Attempted to add Saint David Dairy products to test order cycle.
  4. Could see that only 6 products available. As above should be 10.
  5. Unable to add all Saint David's Dairy products to test order cycle, as experienced by the customer who reported the bug.

Workaround

The products were recreated and added then were able to be added to Fawkner Commons order cycle. ## Severity bug-s3: a feature is broken but there is a workaround ## Your Environment
luisramos0 commented 4 years ago

Hello @RonellaG I dont see the problem in 3 latest OCs of Fawkner Commons, for example, https://openfoodnetwork.org.au/admin/order_cycles/5840/incoming image

What OC are you looking at?

RachL commented 4 years ago

@luisramos0 If I understood correctly they have re-created the products. So I don't think we will be able to reproduce this one. I would be in favor of closing it and reopen if it occurs again but maybe take the time to copy the database before adding the products back?

luisramos0 commented 4 years ago

ah :-( it should be very easy to find out what's the problem if we can replicate in prod :+1:

emilyjeanrogers commented 4 years ago

@RachL and @luisramos0 if this does happen again - is there something we should do re: copying the database before resolving? Is this a dev task or something a superadmin can do?

mkllnk commented 4 years ago

Those four products were created Thu, 02 Jul 2020 15:28:24 AEST +10:00 and deleted Mon, 20 Jul 2020 12:55:11 AEST +10:00. I can't tell who deleted them or why. The product ids are 14962, 14956, 14964, 14961.

Interestingly, v3.1.2 was deployed at that time (start at 12:42). The deletions didn't happen all at the same time though:

I also looked for other products being deleted around the same time and couldn't find any. Even though the deployment happened then, a user deleting these products is more likely.

luisramos0 commented 4 years ago

Hello @mkllnk welcome back! Hello @emilyjeanrogers if this happens again, the only requirement is really, dont fix it by re-creating products. Just let us know so we can have a look while it's broken. We can probably just take a backup of the DB (a dev task) and let the user fix/recreate the products afterwards.

mkllnk commented 4 years ago

Or if a dev is not instantly available and you need to apply the workaround quickly, note the time of the workaround so that we can look for a backup before that time.

emilyjeanrogers commented 4 years ago

@mkllnk I'm thinking we should close this issue for the moment? If it happens again we can re-open yes?

mkllnk commented 4 years ago

I agree, I'm closing this.

RonellaG commented 4 years ago

It seems to me that Issue #5820 has happened again. Last night when Fawkner Commons (1441) went to setup a new order cycle some of the products from Saint David Dairy (826) were missing from the hub's inventory as well as the producer's product list.

I checked and Fawkner Commons’s last three order cycles (not including the Meat order cycle) only included 3 Saint David Dairy products instead of the full list. Fawkner Commons only raised the issue this morning so I have asked them to confirm if that was meant to be the case or if there were meant to be more products available for those order cycles too.

The order cycle was meant to open at 8am today (2 hrs ago) so she needs help with this as soon as possible. Is someone able to help with this now or should I create the workaround and note the time?

mkllnk commented 4 years ago

I created a database backup for this issue: /home/openfoodnetwork/openfoodnetwork-issue5820.sql.gz

RonellaG commented 4 years ago

I have recreated the products and am waiting on Fawkner Commons to respond with updates.

RonellaG commented 4 years ago

Fawkner Commons was able to include Saint David Dairy products that I recreated today into their order cycle but it is still a mystery as to why they disappeard.

chezaorchard commented 4 years ago

Noting this issue, disappearing products of a producer, has now happened for other hubs (2939, 2759, 2941) in Aus - when they opened their recent order cycles all the products for Red Cow Organics (3020) were missing. The hub solved the issue for themselves by recreating the products from scratch (after 9:15am Sunday 20 EST) so I this is no longer a 'live' issue for the customer.

emilyjeanrogers commented 4 years ago

Aus support were notified on Sunday 20th at 9.15am by the customer, but by Monday 21st at 9.58am the products had been reinstated by the customer so we were unable to log this while the products were missing.

Matt-Yorkley commented 4 years ago

Okay, I downloaded the database dump here and have had a look at the case for the Fawkner Commons OC around the 28th of August. I can see that a number of relevant products were deleted on the 24th August. These products (from Saint David Dairy) were:

I honestly can't see any way these products could have been deleted other than by an enterprise user (with access to manage products for Saint David Dairy) deleting them, which as far as I can tell is also what happened the first time this issue was opened (and then closed) in July.

Matt-Yorkley commented 4 years ago

Unless there are some new developments here, I can't see that there's any further action that devs can currently take, either in terms of investigating or bug-fixing...