openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.1k stars 717 forks source link

Inventory is not showing "On-demand" when using producer settings #5970

Open Cecilia-Hn opened 4 years ago

Cecilia-Hn commented 4 years ago

Description

From Inventory, when a hub chose to Use producer stock settings from the On demand column, the showed information in the On hand column is the stock previously set up in a grey color box, even when producer decided to chose On demand from Products list

Hub can not see clearly that producer have chosen to distribute their products On demand

Expected Behavior

When producer have chosen to distribute On demand one of his products, a hub, should be able to see it from his inventory, just like when the hub is setting on demand himself.

Actual Behaviour

IMAGE 1 Producer chose On demand for a product from Products IMAGE 2 Hub chose to use producer stock settings for a product from Inventory, they see from On hand column in a grey box the last number of products entered by the producer, not the On demand choice.

Capture d’écran 2020-08-31 à 16 09 25 Capture d’écran 2020-08-31 à 16 09 35

Steps to Reproduce

  1. From Products list, find a product with box cheked On demand
  2. Find the same product from Inventory list
  3. Chose Use producer stock settings from On demand column
  4. Check that from the On hand column there is no "on demand" notion but a grey box with number

Animated Gif/Screenshot

Workaround

Hub can know, by the grey color box, that producer have chosen the On demand distribution

Severity

Bug S3, I think it would be helpfull to have a clear information but we can easily explain to user how it works from now

Your Environment

Possible Fix

adele-ofn commented 2 years ago

We've had a hub get in contact with the Aus customer support team with the same concern. They were particularly confused because one product showed 0 on hand (but still appeared in the shopfront because it'd inherited the "on demand" property) Screen Shot 2021-10-25 at 6 09 11 pm Screen Shot 2021-10-25 at 6 09 50 pm Screen Shot 2021-10-25 at 6 15 09 pm Screen Shot 2021-10-25 at 6 23 21 pm Screen Shot 2021-10-25 at 6 23 55 pm .