search

openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.09k stars 708 forks source link

Remove jquery-ui-rails #6665

Open RachL opened 3 years ago

RachL commented 3 years ago

What we should change and why (this is tech debt)

After https://github.com/openfoodfoundation/openfoodnetwork/issues/6664 we shouldn't have bits that are using jquery-ui-rails. Yet let's see if there's any other small jquery-ui bits we use and try to replace them. And then remove completely this dependency.

Context

See https://github.com/openfoodfoundation/openfoodnetwork/pull/6482

jibees commented 3 years ago

A far as i know, jquery-ui-rails is used to display the dialog modal (ui-widget-overlay, ui-dialog, ... here: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/assets/javascripts/admin/utils/services/dialog_defaults.js.coffee) We should rewrite this part before removing jquery-ui-rails.