openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.12k stars 723 forks source link

Newly created OC do not appear as 'Available' in edit Schedule pop up on bulk OC management page #7071

Open lbwright22 opened 3 years ago

lbwright22 commented 3 years ago

Description

On Order cycle management page hub manager should be able to add their newly created OC to an existing schedule.

Currently no order cycles appear in the 'Available' column of a schedule pop up.

noocinschedule

In this example the OC named March 20th 2021 should appear.

Adding the schedule to an OC from Edit Order Cycle -> General Settings allows the user to create two schedules with identical names as mentioned here thus not generating orders as predicted.

Expected Behavior

Order Cycles not assigned to a schedule for a particular enterprise should appear as 'Available' in the edit schedule pop up accessed by bulk order cycle management page https://openfoodnetwork.org.uk/admin/order_cycles

Actual Behaviour

No Order Cycles appear as 'Available' in the edit schedule pop up accessed by bulk order cycle management page https://openfoodnetwork.org.uk/admin/order_cycles

Steps to Reproduce

  1. hub with subscriptions enabled. Create a new order cycle
  2. From the page https://openfoodnetwork.org.uk/admin/order_cycles click on an existing schedule to bring up the edit schedule pop up
  3. Observe the newly created order cycle is not visible under the 'Available' column

Animated Gif/Screenshot

Workaround

Use the Edit Order Cycle page to add schedule instead. Bear in mind bug here which results in many users not being able to generate their subs orders.

Severity

S3

Your Environment

Possible Fix

filipefurtad0 commented 3 years ago

Perhaps a helpful workaround (not really a solution) is to remove some OC's from the "Available" section, and adding them back again as needed:

Peek 2021-04-01 18-05

It seems there are some pain points around this Schedule pop-up, here's another one: openfoodfoundation/wishlist#283