openfoodfoundation / openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce.
https://www.openfoodnetwork.org
GNU Affero General Public License v3.0
1.11k stars 718 forks source link

Translations not applied consistently (?) (USA, en_US) #7094

Open lauriewayne opened 3 years ago

lauriewayne commented 3 years ago

Description

We are seeing that some translations are applied to match Transifex, and some are not. Sometimes a translation shows up on one context and not in a seemingly identical context. In most cases this is just annoying though it erodes user confidence that OFN is "for" the US and thus impacts user adoption, but when we use translations to convey key information (like changing the name of the non-SCA Stripe payment provider to keep people from using it as part of the SCA rollout strategy) it impacts user success.

The four different examples below may not represent the same problem, but they seem to be related to each other and under the big umbrella of "Transifex translations not propagating as expected".

Expected Behavior

Translations should show up in user interface.

Actual Behaviour

Translations may or may not show up

Steps to Reproduce

  1. Update transifex
  2. Wait for release
  3. See if translation "stuck" in all places

Animated Gif/Screenshot

Example 1: Payment method name not updated Transifex: (Stripe="retired, please use Stripe SCA") image

User sees: image

Example 2: Invoice verbiage not updated Transifex (GST=Tax; "Tax Invoice" = "Invoice"): image image

User sees: image

Example 3: Tax and business terminology (default is GST, ABN and ACN) are correct on sign up modal but not in enterprise settings under “business details” Transifex: image image

User sees: image image

Example 4: Inconsistent translation on order confirmations Transifex: image

User sees: image or, same shop, same day: image

Workaround

In most cases it's just a quick answer to a support call if user cares to make a call. We have been living with it but with the Stripe SCA rollout we came across a need to understand why and when translations aren't seen by the user since they drive user behaviour.

Severity

bug-s4: it's annoying, but you can use it

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity -->

Your Environment

Possible Fix

lauriewayne commented 3 years ago

An update - after @andrewpbrett was reprovisioning the server to include Spanish, it looks like all of the translations mentioned above are now live. Leaving open for now to see if a reprovisioning will be required in the future (so maybe that would be the bug).

RachL commented 3 years ago

@lauriewayne hello! Have you experienced any other issues lately?

lauriewayne commented 3 years ago

Bonjour @RachL ! Yes this problem is still occurring in various places - hard to predict or isolate since our translations are mostly close and users just think it's all normal (at least the ones who use English). For example I changed the text on the "welcome" email and sometimes that translation comes over and sometimes it doesn't. The biggest issue is on the invoices, because people do care about some of the words on them. It's so annoying that it seems so unpredictable (I am sure there is a rational explanation)! Welcome letter email examples attached here (incorrect from 15 June and correct from 16 June). Here is a sample of dates for the "is now on" emails:

4 June - correct (as translated that is) 6 June - incorrect 11 June - incorrect 12 June - correct x 2 (yay maybe it's fixed!) 15 June - incorrect (sad face) 16 June - correct

Is Now On inCorrect.pdf Is Now On Correct.pdf

RachL commented 1 year ago

@abdellani I've noticed a similar strange behavior on staging FR: if I bulk print invoices, they always show up in French (primary language of the server). However if I print them individually, I can make them show up in English. EDIT: this is working now

I don't know if it's worth looking into it before implementing the new template, but I'm adding this to the list of issues in the invoice epic so we don't forget to test during next phases.

dacook commented 1 year ago

Regarding bulk print invoices, I've just found that is a different bug which will be fixed in https://github.com/openfoodfoundation/openfoodnetwork/pull/11627

RachL commented 10 months ago

@lauriewayne we have fixed some translations issues lately, did it by any chance fixed your problems as well? At least I'm not able to reproduce any translation problems anymore.

lauriewayne commented 10 months ago

Oooh great, thank you I will check! :-)

On Mon, Nov 20, 2023 at 6:39 AM Rachel Arnould @.***> wrote:

@lauriewayne https://github.com/lauriewayne we have fixed some translations issues lately, did it by any chance fixed your problems as well? At least I'm not able to reproduce any translation problems anymore.

— Reply to this email directly, view it on GitHub https://github.com/openfoodfoundation/openfoodnetwork/issues/7094#issuecomment-1819189886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJANJZWK5WVKW4Z6CWPJEYLYFNTRPAVCNFSM4ZCYE35KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBRHEYTQOJYHA3A . You are receiving this because you were mentioned.Message ID: @.***>

sigmundpetersen commented 10 months ago

I think this is related also: #ofn-install/669