Closed jibees closed 2 years ago
@openfoodfoundation/core-devs a comment on the release template issue: I never use the link next to the testing checkbox to stage, always https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master/builds/3679 am I doing something wrong? Otherwise maybe the template can be updated.
You're right, we need to test that build ie. https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master/builds/3679
because it's the build of the commit on which the release is drafted.
Not sure to understand what for stand the other link (ie. https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master
)
yep me neither, I think we can remove it.
Testing done, another one ready to ship! ⛵
https://docs.google.com/document/d/1SJQGDKhylYgYcBzS5awFME7kNkd7ATgadkGVi__i5zQ/edit#
Hey guys. I think that the
Find build of the release commit and copy it below.
are instructions for the drafter and that copy it below means copy the link to the step
Test: ⚠️ link to the build of the release commit https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master
and not straight below i.e. next line.
The https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master link is a template meant to be substituted with the actual build link.
😅
So the output in the description should really be:
I agree it's a bit confusing and could be improved. I may not have the correct understanding either 🙂
Maybe the two steps "Find build" and "Move this issue" could be moved up to the "Preperations" section?
No, I think you're right: I misunderstood the below ;)
If you read at @mkllnk issue, like this one: https://github.com/openfoodfoundation/openfoodnetwork/issues/9471 It's way cleaner !
Thanks @sigmundpetersen will take care the next time! Sorry for the confusion @RachL !
I tried to clarify: https://github.com/openfoodfoundation/openfoodnetwork/commit/63d2d69d08e3002bb1d3bde0916207d041375112
This also removes the need to replace text. There's just an empty space now.
Preparation on Thursday
tx pull --force
Testing
Finish on Tuesday
Command line instructions
Command line instructions
The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.