openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Producer Profile: View buying info and links (clarify logic for contact form) #11

Open kirstenalarsen opened 2 months ago

kirstenalarsen commented 2 months ago

Needs test data to make sure we have all the scenarios represented

Test Data:

Changes needed [] Add Contact Producer Button [] ? Wholesale Customers title

Image

JbPasquier commented 2 months ago

I don't understand what needs to change here? Can you clarify, please?

mariocarabotta commented 2 months ago

I don't understand what needs to change here? Can you clarify, please?

You can find different scenarios mocks and annotations here.

Feel free to let me know if you need further details

mariocarabotta commented 2 months ago

also, I'm noticing this icon? not sure why it's there since we don't have whatsapp links https://ofn-rpp.startinblox.com/regenerative-produce-portal-producer-details/@https%3A//api.regenerative.org.au/webhook/regen/producer%3Fid%3DrecmepDXsFPzYibCv@

Image

mariocarabotta commented 2 months ago

here I'm seeing multiple facebook links. @mkllnk looping you in since we might need to handle it our side?

JbPasquier commented 2 months ago

You can find different scenarios mocks and annotations here.

This is the document I based the implementation on. If anything is wrong, maybe it's worth checking related datas.

Can you point some producers which have wrong display?

also, I'm noticing this icon? not sure why it's there since we don't have whatsapp links

Datas have.

mkllnk commented 2 months ago

I just checked that link and I could see only one Facebook link now. Maybe fixed?

kirstenalarsen commented 2 months ago

@JbPasquier the problem as I see it is that

1. 'Wholesale Customers' title not displaying

when Wholesale Customers is on, there should be a title INSIDE the box, between How to Buy and the info, as per mockup

Image

Looking at Bundarra, the wholesale customer info is there but the TITLE is missing

Image

2. View Contact Details button missing

Underneath the Wholesale Customer section there should be a button that takes the User down to the contact form

kirstenalarsen commented 2 months ago

just looking for different cases for this - Grazed and Grown is not displaying any 'how to buy' section at all - can anyone see why this might be? https://regenerative.org.au/regenerative-produce-portal-producer-details/@https%3A//api.regenerative.org.au/webhook/regen/producer%3Fid%3Drec2aFRu0H3Czf2IG@ @mkllnk @mariocarabotta @JbPasquier

JbPasquier commented 2 months ago

Looking at Bundarra, the wholesale customer info is there but the TITLE is missing

Fixed

Underneath the Wholesale Customer section there should be a button that takes the User down to the contact form

The mockup said this: image

In your datas, Bundarra does not have phone enabled.

Grazed and Grown is not displaying any 'how to buy' section at all - can anyone see why this might be

This producer have no product. That's the condition I've made to display the whole How to buy block to avoid empty screen. Should I remove this check?

mariocarabotta commented 1 month ago

This producer have no product. That's the condition I've made to display the whole How to buy block to avoid empty screen. Should I remove this check?

Please remove the check. It will look empty, but we will encourage producers to add products, so it should not happen frequently.

@JbPasquier we have discussed internally about always showing the contact form - hopefully this might simplify the logic a little bit.

I have prepared some examples of how that would look like here

JbPasquier commented 1 month ago

Done!

It will look empty, but we will encourage producers to add products, so it should not happen frequently.

I hope so, some like the Tak-One Organics producer page are rather deceptive.

the email address will be used to send the message from the form (this might be with Maikel maybe)

That's with Maikel, indeed. It seems that it's already done.

mariocarabotta commented 1 month ago

I hope so, some like the Tak-One Organics producer page are rather deceptive.

agree! there are a couple of people in the team helping out producers filling their profile. Also, at the moment the profiles that are still in progress get published for our testing, but before we go live we'll hide the ones that are not ready.

thanks for updating this! I went through most of the profiles, just a few prodycers still show the phone number at the top below the button. it might be some logic from the previous design iteration (sorry about that!). if you could remove it, that would be great. we would like to show phone number and email address ONLY next to the contact form.

a couple of examples of where this is happening here > Grazed and Grown Farm, Moyarra Pastoral

Screenshot 2024-03-26 at 10 20 00

JbPasquier commented 1 month ago

Found, thanks. Fixed.

mariocarabotta commented 1 month ago

working great! moving to done 👏