openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Producer Profile: assurance partner list #13

Open kirstenalarsen opened 2 months ago

kirstenalarsen commented 2 months ago

Image

kirstenalarsen commented 2 months ago
  1. The wrong logo is showing for Sustainable Table Assurance Partner - anyone know where this is coming from?

Image

  1. This is currently not showing on the Producer page for Pukawidgee. I assume this is because it is not yet confirmed . . ? I think is probably correct behaviour at this stage to just not show it .. there shouldn't be any cases of this when we go live

Image

Image

kirstenalarsen commented 2 months ago

Need to set a test case for AHMC

JbPasquier commented 2 months ago

The wrong logo is showing for Sustainable Table Assurance Partner - anyone know where this is coming from?

You api. @mkllnk This one https://api.regenerative.org.au/webhook/regen/group?id=recT7DLShx9TbwqV2

This is currently not showing on the Producer page for Pukawidgee. I assume this is because it is not yet confirmed . . ? I think is probably correct behaviour at this stage to just not show it .. there shouldn't be any cases of this when we go live

@mkllnk Pukawidgee does not have any ofn:hasAssurancePartnerships. Is it expected? https://api.regenerative.org.au/webhook/regen/producer?id=recjBYlXskXtilPBC

mariocarabotta commented 2 months ago

@kirstenalarsen this is correct. only confirmed partnerships should be shown. We'll fix the image from our end. @mkllnk let me know how best to provide or replace image

mkllnk commented 2 months ago

The image of an assurance partner is coming from Airtable:

There you can set another logo URL.

kirstenalarsen commented 2 months ago

@amidaOFN could you action this one please? maybe check with Marti or Prue which ST logo to use . .

AHMC logo currently broken

Image

Also @JbPasquier @mariocarabotta now that this panel has more data in it, is clear that it is not responding properly on mobile - could we have some responsive tweaks please?

mariocarabotta commented 2 months ago

@JbPasquier for mobile: if you can change the breakpoint to below 700px instead of 600px that would be great, thanks!

JbPasquier commented 2 months ago

@JbPasquier for mobile: if you can change the breakpoint to below 700px instead of 600px that would be great, thanks!

Done

kirstenalarsen commented 1 month ago

Supporting Evidence summary now ok, but the case with two Assurance Partners is breaking too early i.e. they don't seem to ever appear side-by-side even when plenty of room

Image

@mariocarabotta tip for @JbPasquier on this one?

kirstenalarsen commented 1 month ago

@amidaOFN note both AHMC and Sustainable Table logos are broken and need to be fixed. They are being pulled from the Airtable somewhere

mariocarabotta commented 1 month ago

I have updated them manually in airtable. this might take some time to be reflected in the staging environment i guess

kirstenalarsen commented 1 month ago

thanks @mariocarabotta. and what do you think about the responsive thing

mariocarabotta commented 1 month ago

thanks @mariocarabotta. and what do you think about the responsive thing

Sorry I was just waiting for the logos to update, but seems like it's taking a while.

@JbPasquier please find below a rough idea of how the assurance partners and supporting evidence list could scale down at different sizes. hopefully that helps a bit with the responsive side

https://www.figma.com/file/jCheM9rB3tzfdPyIZcmcM9/Engineering-Delivery---Discover-Regenerative?type=design&node-id=490%3A45&mode=design&t=TyXUvCE2krmwWAsK-1

JbPasquier commented 1 month ago

Thanks. Fixed.

image

You may want to remove white space in the Sustainable Table image used in your datas if you want to align it the same way as the mockup ( This one: https://regenerative.org.au/wp-content/uploads/2024/01/sustainable_table_logo.png )

mariocarabotta commented 1 month ago

Thanks. Fixed.

image

You may want to remove white space in the Sustainable Table image used in your datas if you want to align it the same way as the mockup ( This one: https://regenerative.org.au/wp-content/uploads/2024/01/sustainable_table_logo.png )

great! yep good suggestion, I have now tweaked the logos so that they should align properly.

kirstenalarsen commented 1 month ago

yep great