openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

View producer basic details #17

Closed kirstenalarsen closed 2 months ago

kirstenalarsen commented 2 months ago

Image

kirstenalarsen commented 2 months ago

When I click into a Producer that has a short profile i.e. not much information, it is scrolling me straight to the bottom so I'm only looking at the footer

Image

and I have to scroll up to see the actual info

Image

This is in the wordpress embed (regenerative.org.au/test) not the SiB staging site so it might be wordpress related @mkllnk

mkllnk commented 2 months ago

@JbPasquier, can you shed some light on this? How does it scroll? Which anchor does it use?

JbPasquier commented 2 months ago

I found an issue in the SIB Router, I fixed it, Benoît will merge it as soon as he'll be able to review it.

JbPasquier commented 2 months ago

It has been merged, @mkllnk can you update your WP's head to these lines:

<script type="module" src="https://cdn.skypack.dev/@startinblox/core@0.19"></script>
<script type="module" src="https://cdn.skypack.dev/@startinblox/router@0.12"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/@startinblox/component-ofn-rpp"></script>

(router@0.12 instead of router@0.11)

mkllnk commented 2 months ago

Yay, it works!

mariocarabotta commented 2 months ago
  1. location format under the name is not as expected. it should be {City} - {State} {First Nations Country}

Note: First Nations Country is optional

Image

  1. if possible, could you please move the tags above the title? We're noticing people adding loads of categories and it breaks the layout. Apologies for this, I was not expecting it.

current Image

expected (if possible) Image

  1. Learn more about us needs underline style

  2. Align title and line divider to rest of elements. See below for gaps Image

JbPasquier commented 2 months ago

Done.

image