search

openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Filter Producer by First Nations led #18

Closed kirstenalarsen closed 2 months ago

kirstenalarsen commented 2 months ago

First Nations led filter is currently not working correctly

Image

Part of the problem might be data @mkllnk @mariocarabotta - can we confirm that the API is bringing the correct data? The results displayed on the page are showing some Producers as FNL that shouldn't be i.e. Pukawidgee, Bundarra and Murrnong (despite them all being named with Aboriginal words!!) I'm not sure the correct spot to look in the airtable, but when I'm looking I don't see them as having FNL set, so not sure why that flag is appearing on the profiles

Image

mkllnk commented 2 months ago

@JbPasquier acknowledged already that it's a framework issue on SiB side. The current version is feeding from the wrong field in the absence of being able to deal with the right field. Oh wait, just saw that one comment was edited:

I still have a framework issue with the first nation led filter on products list. A fix will come as soon as possible. - Edit: Fixed.

@JbPasquier, maybe you missed an earlier comment on Slack:

One thing we noticed is that the First Nations Led filter isn't right. There was no test data but we added that flag to an enterprise now: https://api.regenerative.org.au/webhook/regen/producer?id=recSrhBnWnzkFRS3y There you can see the ofn:First_Nations_led field which is only present when set and then it's simply true (boolean).

I think that you are looking at ofn:First_Nations_country but you need to look at ofn:First_Nations_led.

JbPasquier commented 2 months ago

Oooh right, I was using the wrong field so. Fixed.

image

Can you add a produce to this producer to ensure that the filter on Products List works properly too?

mkllnk commented 2 months ago

@kirstenalarsen We can't add products to that enterprise but could we add that flag to another with products?

JbPasquier commented 2 months ago

Should I keep the First Nation Country when First Nations Led is false?

Like there for Pukawidgee for instance:

image

mkllnk commented 2 months ago

Should I keep the First Nation Country when First Nation Led is false?

Yes! In Australia, we all live on First Nation's Country but only very few organisations are led by Indigenous people. We want to acknowledge the traditional owners regardless of being indigenous to this land or not.

kirstenalarsen commented 2 months ago

I just created a test product for Laguna. we can clean it up later, will be working with Producers to try and get a few products in each before launch

piong @Amida Cumming @.***>

On Fri, 8 Mar 2024 at 10:46, Maikel @.***> wrote:

Should I keep the First Nation Country when First Nation Led is false?

Yes! In Australia, we all live on First Nation's Country but only very few organisations are led by Indigenous people. We want to acknowledge the traditional owners regardless of being indigenous to this land or not.

— Reply to this email directly, view it on GitHub https://github.com/openfoodfoundation/sib-discovery-components/issues/18#issuecomment-1984793105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWGXSFEJVSEVDICQHYDZBDYXD37DAVCNFSM6AAAAABELUHWVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUG44TGMJQGU . You are receiving this because you were mentioned.Message ID: @.*** com>

mariocarabotta commented 2 months ago

working as expected, product filter as well (see The Regenerative Farm DR Example).

Moving to done, good job!