openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Producers: 'Supporting Evidence' Filter (remove Certifications label) #21

Closed kirstenalarsen closed 1 month ago

kirstenalarsen commented 2 months ago

Consolidated list of Supporting Evidence classifications: https://n8n.openfoodnetwork.org.uk/webhook/regen/supporting_evidence_classifications

kirstenalarsen commented 2 months ago

excellent, a big step forward!

Image

[Y] The title of this needs to be 'Supporting Evidence' not 'Ecological Outcomes' [] Needs to be multi-select as per #20 [] The Certifications button needs to select all Producers that have a Certification (same function as mentioned in #12239 could be an API thing, @mkllnk )

Currently only giving me the one that is certified biodynamic Image

[Y] Ordering - please make 'Other' appear at the bottom (same for on the Evidence filter)

JbPasquier commented 2 months ago

The Certifications button needs to select all Producers that have a Certification (same function as mentioned in https://github.com/openfoodfoundation/openfoodnetwork/issues/12239 could be an API thing, @mkllnk )

Exact, doing it in the API datas is the only way to handle that. I can't mix-match things like that.

JbPasquier commented 2 months ago

Ordering - please make 'Other' appear at the bottom (same for on the Evidence filter)

To reach this, we should avoid ordering on client-side and have it at the end of the list on the API.

JbPasquier commented 2 months ago

The title of this needs to be 'Supporting Evidence' not 'Ecological Outcomes'

Done.

mkllnk commented 2 months ago

Ordering - please make 'Other' appear at the bottom (same for on the Evidence filter)

Done in the API. Should be visible tomorrow.

kirstenalarsen commented 2 months ago

We have discussed and the problem is in the data.

We are not clear what we WANT this to do . .

Kirsten feeling would be that:

kirstenalarsen commented 1 month ago

OK, we've made some decisions. We are going to remove 'Certifications' as a tag on Supporting Evidence as it's confusing and duplicative. To action this:

@mariocarabotta can you please remove in Airtable / Miniextensions @mkllnk can you please remove from API if needed @JbPasquier can you remove the Certifications label from the Supporting Evidence dropdown, if it doesn't disappear automatically after the above!

Thanks!

mariocarabotta commented 1 month ago

removed from airtable

mkllnk commented 1 month ago

Removing from Airtable was enough, there was not special data held in n8n. Ready for testing.

kirstenalarsen commented 1 month ago

yep