openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Product list - tweaks to product tile #42

Open mariocarabotta opened 1 month ago

mariocarabotta commented 1 month ago

I understand this might be a bit tricky given that there's going to be some dynamic height involved. happy to discuss if fixing everything is problematic.

To see something similar in action, an example of responsive dynamic height tiles can be found here

Example of a tile Image

Example of a row with multiple heights - the height of the row should follow the tallest tile Image

Image

Image

Image

JbPasquier commented 1 month ago

add 4px border radius to image add 4px spacing between image and text image should align to text (while still retaining equal left, right and top padding)

Done

image size should always be square. at the moment sometimes it resizes horizontally only

This was an unexpected behaviour for sure. I only set square, but I also made it so that if there aren't enough place to put the whole square, it should always fit. I was able to reproduce your exact fit with a custom resolution of 1202px wide. Fixed.

don't truncate product name. it should wrap don't truncate Producer name. it should wrap

This one was definitely tricky due to the way the Startin'blox framework displays datas. Done.

mariocarabotta commented 1 month ago

great work