openfoodfoundation / sib-discovery-components

Development and application of Startin'Blox Discovery components, initial use in Discover Regenerative www.regenerative.org.au
1 stars 0 forks source link

Producer listing: Images covering text (on google pixel, chrome) #47

Open kirstenalarsen opened 1 month ago

kirstenalarsen commented 1 month ago

Image

kirstenalarsen commented 1 month ago

they're back

mariocarabotta commented 1 month ago

they're back

what do you mean?

logos are still overlapping in my phone

mariocarabotta commented 3 weeks ago

temporarily fixed in WP css by modifying the style below

@media only screen and (max-width: 700px) { [name=set-card-panel] [name=set-right-panel] [name=set-title] { margin-left: 110px; } }

mariocarabotta commented 3 weeks ago

the above solution is not good enough. it looks like logos are not positioned all at the same height, causing some weird overlap in some cards:

Image Image Image

JbPasquier commented 3 weeks ago

Same as before, this come from your wordpress style rules.

font-size: var(--wp--preset--font-size--medium);

I'll force some style within the component.

mariocarabotta commented 2 weeks ago

this is happening in the component test environment as well. anyway, I'm moving it back to after launch, it's sort of good enough for now.